Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder attributes in doc to match order in header #1494

Conversation

JGoldstone
Copy link
Contributor

In addition to reordering the attributes in the documentation to match those in ImfStandardAttributes.h, the documentation's misspelling of expTime as exposure was also corrected. What does it say about the use of standard optional attributes that no one ever noticed that before?

Signed-off-by: Joseph Goldstone <jgoldstone@arri.com>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm
Copy link
Member

Prior to the website overhaul in February, the term "exposure" appeared only in the comment in ImfStandardAttributes.h, so would only have been visible to those looking at the code, for what that's worth. But yeah, sort of surprising no one commented on that.

@cary-ilm cary-ilm merged commit cfd1c76 into AcademySoftwareFoundation:main Jul 26, 2023
26 checks passed
@JGoldstone JGoldstone deleted the feature/reorder_std_opt_addrs_in_doc branch August 1, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants